build.rs: Add feature 'lowmemory' to reduce memory usage#140
build.rs: Add feature 'lowmemory' to reduce memory usage#140apoelstra merged 2 commits intorust-bitcoin:masterfrom laanwj:2019_08_lowmemory
Conversation
|
ACK 09037fc |
|
If you add a commit bumping the version to 0.15.1 (and setting the date in CHANGELOG.md) I can merge and publish today |
|
Whoops, I didn't realize that the version is already at |
|
Do we think 3 is good is that "too low" to be reasonable? |
|
Oh, yeah, 0.15.1 just had a docs.rs fix. @real-or-random for embedded applications where speed is nonessential I think we want "as low as possible". |
I once did some benchmarks here: bitcoin-core/secp256k1#614 (comment)
|
|
added version bump to 0.15.2 and updated the changelog accordingly ! |
If you want as low as possible, that's "2" and not "3". @laanwj Can you update this? (I restarted Travis, which had some hiccup). |
|
Travis is still having problems :/ |
That would be 340 to 170 bytes? don't know if that's worth it. |
build.rs
Outdated
| .define("USE_EXTERNAL_DEFAULT_CALLBACKS", Some("1")); | ||
|
|
||
| if cfg!(feature = "lowmemory") { | ||
| base_config.define("ECMULT_WINDOW_SIZE", Some("3")); // This is the lowest accepted value by configure |
There was a problem hiding this comment.
If we want anything > 2, then we shouldn't claim that this is the lowest accepted value.
|
OK, I'll set it to 4 and remove that comment. |
Currently, this only set `ECMULT_WINDOW_SIZE` to 4 instead of 15. Fixes #139. fixup
And fill in release date for 0.15.2.
|
Published 0.15.2 |
4 participants
Currently, this only set
ECMULT_WINDOW_SIZEto 4 instead of 15.Fixes #139.